[NativeAOT-LLVM] Smoke test non-x64 ILC on Helix instead of using emulation #3179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SingleAccretion
force-pushed
the
Helix-Validation
branch
9 times, most recently
from
cfd288b to
d7445a9
Compare
SingleAccretion
changed the title
SingleAccretion
force-pushed
the
Helix-Validation
branch
4 times, most recently
from
39603b1 to
e3f68cd
Compare
SingleAccretion
force-pushed
the
Helix-Validation
branch
from
e3f68cd to
baf636a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying goal here is to enable win-arm64 testing.
The main obstacle to this is the fact we can't test it with out existing approaches. There are no win-arm64 build machines, and there is no user mode qemu for Windows either.
The only remaining option is Helix (see https://github.com/dotnet/arcade/tree/main/src/Microsoft.DotNet.Helix/Sdk#readme). Thus, this change moves our testing of linux-arm64 from qemu to Helix. This is done by sending our samples and WASI SDK over, along with the published packages, and compiling those samples. It is very light validation, but doing more is both more complicated infrastructure-wise, and not absolutely necessary since the property we want to test is effectively that we compiled and linked the Jit correctly. We don't have, and don't expect to add, host-specific code to the Jit.
Along the way, I also had to change the platform from which we publish "host" packages from browser to WASI since sending the EMSDK over is rather more complicated than sending WASI SDK, and it's not as easy to procure one for ARM64 platforms. And we only need one ARM64 job per host OS.